Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool: add timeout to ceph cmd #10721

Merged
merged 1 commit into from
Oct 12, 2022
Merged

pool: add timeout to ceph cmd #10721

merged 1 commit into from
Oct 12, 2022

Conversation

zhucan
Copy link
Member

@zhucan zhucan commented Aug 15, 2022

Signed-off-by: zhucan zhucan.k8s@gmail.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #10712

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhucan The CI failures seem consistent though I don't see how they're related. Could you rebase this on the latest master to see if some fixes are picked up?

@zhucan
Copy link
Member Author

zhucan commented Aug 22, 2022

@travisn done

@travisn
Copy link
Member

travisn commented Aug 22, 2022

@travisn done

Thanks, though looks like the same error is happening for the pool resize test...

@zhucan
Copy link
Member Author

zhucan commented Sep 14, 2022

@travisn Can it be mergerd?

Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhucan I restarted the failing CI again but seems like somehow ci failing due to the changes. Can you look at the CI errors?

@zhucan
Copy link
Member Author

zhucan commented Sep 14, 2022

@zhucan I restarted the failing CI again but seems like somehow ci failing due to the changes. Can you look at the CI errors?

It looks like timeout of pool size.

@subhamkrai
Copy link
Contributor

@zhucan I restarted the failing CI again but seems like somehow ci failing due to the changes. Can you look at the CI errors?

It looks like timeout of pool size.

try increasing the timeout and see if the tests are passing otherwise CI will always fail.

@zhucan
Copy link
Member Author

zhucan commented Sep 14, 2022

@zhucan I restarted the failing CI again but seems like somehow ci failing due to the changes. Can you look at the CI errors?

It looks like timeout of pool size.

try increasing the timeout and see if the tests are passing otherwise CI will always fail.

yes, i'm trying to increase the timeout to the test.

@zhucan
Copy link
Member Author

zhucan commented Sep 14, 2022

@subhamkrai The same result.

Signed-off-by: zhucan <zhucan.k8s@gmail.com>
Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed track of this

@travisn travisn merged commit 4c11ba7 into rook:master Oct 12, 2022
travisn added a commit that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The status of cephblockpoool is always "Progressing"?
5 participants