Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: fix unexpected end of stream #10899

Merged
merged 1 commit into from Sep 7, 2022
Merged

manifest: fix unexpected end of stream #10899

merged 1 commit into from Sep 7, 2022

Conversation

khrisrichardson
Copy link
Contributor

Description of your changes:

Using the kpt render-helm-chart function to generate YAML results in failed to parse input bytes: yaml: line 583: found unexpected end of stream when encountering --- in the hostPath description of the cephnfses.ceph.rook.io CRD. 馃槙

This is take two. I prematurely closed #10891 when @subhamkrai noted that the descriptions were auto-generated from content upstream, but then soon discovered that there is some agency over post-rendering via yq in the build-crds.sh script.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to see the fix. Can you look at ci commitlint error?

@khrisrichardson khrisrichardson changed the title fix unexpected end of stream crd: fix unexpected end of stream Sep 6, 2022
@khrisrichardson khrisrichardson changed the title crd: fix unexpected end of stream manifest: fix unexpected end of stream Sep 6, 2022
@khrisrichardson
Copy link
Contributor Author

@subhamkrai I addressed the commit lint issues, but do you have any recommendations for dealing with the tmate timeouts?

@travisn
Copy link
Member

travisn commented Sep 6, 2022

The CI is failing with this error, though i'm not clear on the issue since the new script line follows the same pattern as the line above it.

Generating CRDs into dir /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.cFCYOmkm
Generating ceph crds
Error: cannot substitute with !!null, can only substitute strings. Hint: Most often you'll want to use '|=' over '=' for this operation.
make[4]: *** [crds] Error 1
make[3]: *** [generate-csv-templates] Error 2

Signed-off-by: Khris Richardson <khris.richardson@gmail.com>
@khrisrichardson
Copy link
Contributor Author

@travisn it looks like there are two swipes at the crds Makefile target, once without the descriptions populated [make csv-ceph](csv-ceph: csv-clean crds) and once with [make crds](crds: $(CONTROLLER_GEN) $(YQ)). So the yq syntax needed to be sensitive to description being null. Thanks for pointing me in the right direction.

@satoru-takeuchi
Copy link
Member

Two test failed but they seems to be intermittent failures.Re-running tests.

@travisn travisn merged commit 46a832f into rook:master Sep 7, 2022
@khrisrichardson khrisrichardson deleted the found-unexpected-end-of-stream branch September 7, 2022 14:44
travisn added a commit that referenced this pull request Sep 7, 2022
manifest: fix unexpected end of stream (backport #10899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants