operator: make imagePullPolicy customizable for csi driver and ceph pods #10966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. @avanthakkar please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork |
avanthakkar
force-pushed
the
customizable-image-pull-policy
branch
3 times, most recently
from
65bc798
to
403dd98
Compare
subhamkrai
requested changes
Sep 13, 2022
avanthakkar
force-pushed
the
customizable-image-pull-policy
branch
from
403dd98
to
a49703a
Compare
travisn
requested changes
Sep 13, 2022
|
and please ignore my comment in our separate discussion that this overlapped with #10956, it's really a separate feature, thanks. |
7 tasks
avanthakkar
requested review from
subhamkrai and
travisn
and removed request for
subhamkrai
avanthakkar
requested review from
subhamkrai
and removed request for
travisn
subhamkrai
requested changes
Sep 14, 2022
avanthakkar
force-pushed
the
customizable-image-pull-policy
branch
from
39b5d72
to
3589436
Compare
|
@avanthakkar Why do we need to configure image pull policies for both CSI and Ceph images separately? Won't a single configuration for both ceph and csi images suffice? I don't think user environments would require different imagepullpolicy for different images. |
sp98
reviewed
Sep 14, 2022
sp98
reviewed
Sep 14, 2022
sp98
reviewed
Sep 14, 2022
sp98
reviewed
Sep 14, 2022
sp98
requested changes
Sep 14, 2022
travisn
requested changes
Sep 14, 2022
subhamkrai
requested changes
Sep 14, 2022
avanthakkar
force-pushed
the
customizable-image-pull-policy
branch
3 times, most recently
from
b4a9e56
to
1e38229
Compare
travisn
requested changes
Sep 22, 2022
Madhu-1
reviewed
Sep 22, 2022
Madhu-1
reviewed
Sep 22, 2022
Madhu-1
reviewed
Sep 22, 2022
avanthakkar
force-pushed
the
customizable-image-pull-policy
branch
from
d44d32c
to
18f4ab3
Compare
subhamkrai
reviewed
Sep 22, 2022
avanthakkar
force-pushed
the
customizable-image-pull-policy
branch
5 times, most recently
from
e8af8c6
to
698119a
Compare
travisn
requested changes
Sep 23, 2022
avanthakkar
force-pushed
the
customizable-image-pull-policy
branch
from
698119a
to
a116de9
Compare
travisn
approved these changes
Sep 26, 2022
pkg/operator/ceph/csi/spec.go
Outdated
| @@ -136,6 +137,9 @@ var ( | |||
| DefaultResizerImage = "registry.k8s.io/sig-storage/csi-resizer:v1.5.0" | |||
| DefaultCSIAddonsImage = "quay.io/csiaddons/k8s-sidecar:v0.5.0" | |||
|
|
|||
| // image pull policy | |||
| DefaultCSIImagePullPolicy = "IfNotPresent" | |||
There was a problem hiding this comment.
what about this?
Suggested change
| DefaultCSIImagePullPolicy = "IfNotPresent" | |
| DefaultCSIImagePullPolicy = string(v1.PullIfNotPresent) |
Introduce a new env variable ROOK_CSI_IMAGE_PULL_POLICY in rook operator configmap which should be used to customize the imagePullPolicy for the csi driver and imagePullPolicy property in cephVersionSpec for ceph pods. Signed-off-by: Avan Thakkar <athakkar@redhat.com>
avanthakkar
force-pushed
the
customizable-image-pull-policy
branch
from
a116de9
to
934aa91
Compare
parth-gr
reviewed
Sep 27, 2022
| @@ -32,6 +32,8 @@ Settings can be specified at the global level to apply to the cluster as a whole | |||
| Tags also exist that would give the latest version, but they are only recommended for test environments. For example, the tag `v17` will be updated each time a new Quincy build is released. | |||
| Using the `v17` tag is not recommended in production because it may lead to inconsistent versions of the image running across different nodes in the cluster. | |||
| * `allowUnsupported`: If `true`, allow an unsupported major version of the Ceph release. Currently `pacific` and `quincy` are supported. Future versions such as `reef` (v18) would require this to be set to `true`. Should be set to `false` in production. | |||
| `imagePullPolicy`: The image pull policy for the ceph daemon pods. Possible values are `Always`, `IfNotPresent`, and `Never`. | |||
There was a problem hiding this comment.
just a small question, what will happen if mentioned Never, And image is not present
sp98
approved these changes
Sep 27, 2022
subhamkrai
approved these changes
Sep 28, 2022
travisn
added a commit
that referenced
this pull request
Sep 28, 2022
operator: make imagePullPolicy customizable for csi driver and ceph pods (backport #10966)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avan Thakkar athakkar@redhat.com
Description of your changes:
Introduce a new env variable ROOK_CSI_IMAGE_PULL_POLICY in rook operator configmap which should be used to customize the imagePullPolicy for the csi driver and imagePullPolicy property in cephVersionSpec for ceph pods.
Which issue is resolved by this Pull Request:
Resolves #10783
Checklist:
skip-cion the PR.