-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Improve troubleshooting docs on restoring CRDs after deletion #11154
Docs: Improve troubleshooting docs on restoring CRDs after deletion #11154
Conversation
I don't believe I'm able to add the |
This commit adjusts spacing in the Docs -> Troubleshooting -> Disaster Recovery -> Restoring CRDs after Deletion sources to repair list-numbering-mangling. The section is altered to use spacing suggestions from: https://squidfunk.github.io/mkdocs-material/reference/lists/ Signed-off-by: Alexander Bauer <sasha@linux.com>
3c8ff10
to
3292e28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for improving this doc! Just a tiny suggestion on the note format
3292e28
to
14cf27b
Compare
Just applied that note style change, thank you! I replaced the original commit which added it, and pushed a new pair of commits. |
Signed-off-by: Alexander Bauer <sasha@linux.com>
Signed-off-by: Alexander Bauer <sasha@linux.com>
14cf27b
to
825e956
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The krew plugin could automate all of this, opened an issue: rook/kubectl-rook-ceph#68
Docs: Improve troubleshooting docs on restoring CRDs after deletion (backport #11154)
Description of your changes: These changes make substantial improvements on the Troubleshooting -> Restoring CRDs After Deletion document. The currently published docs are incomplete. This updates them to include instructions surrounding the
ValidatingWebhookConfiguration
, and replaces interactive steps with commands. Additionally, some whitespace issues affecting the markdown parsing of the numbered lists have been fixed.Which issue is resolved by this Pull Request: NA
Checklist:
skip-ci
on the PR.