core: enabling logCollector by default for coredump collection #11163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravsitlani
changed the title
gauravsitlani
changed the title
subhamkrai
requested changes
Oct 18, 2022
There was a problem hiding this comment.
do we require a similar change in cluster-on-pvc.yaml ?
also a thought,
we were discussing adding something similar in krew plugin so can we add something in krew and let users decide if they require this advance debugging?
also, can we make periodicity hourly since this is upstream?
above are just my thought, feel free to add your comment and skip the changes
|
PLease add a commit message in the commit explaining why we need it by default. |
galexrt
requested changes
Oct 18, 2022
|
@parth-gr updated |
travisn
requested changes
Oct 18, 2022
galexrt
reviewed
Oct 19, 2022
| @@ -65,8 +65,8 @@ For more details on the mons and when to choose a number other than `3`, see the | |||
| * `disable`: is set to `true`, the crash collector will not run on any node where a Ceph daemon runs | |||
| * `daysToRetain`: specifies the number of days to keep crash entries in the Ceph cluster. By default the entries are kept indefinitely. | |||
| * `logCollector`: The settings for log collector daemon. | |||
| * `enabled`: if set to `true`, the log collector will run as a side-car next to each Ceph daemon. The Ceph configuration option `log_to_file` will be turned on, meaning Ceph daemons will log on files in addition to still logging to container's stdout. These logs will be rotated. (default: false) | |||
| * `periodicity`: how often to rotate daemon's log. (default: 24h). Specified with a time suffix which may be 'h' for hours or 'd' for days. **Rotating too often will slightly impact the daemon's performance since the signal briefly interrupts the program.** | |||
| * `enabled`: if set to `true`, the log collector will run as a side-car next to each Ceph daemon. The Ceph configuration option `log_to_file` will be turned on, meaning Ceph daemons will log on files in addition to still logging to container's stdout. These logs will be rotated. The coredump files will be generated in `/var/lib/systemd/coredump` directory on the host where the pod is running in case a daemon terminates with a segfault. (default: `true`) | |||
There was a problem hiding this comment.
Are we sure this is the location for all underlying OSes/kernels? What happens when the kernel.core_pattern is not pointing to the coredumpctl/ just a path/directory.
travisn
reviewed
Oct 19, 2022
| @@ -65,8 +65,8 @@ For more details on the mons and when to choose a number other than `3`, see the | |||
| * `disable`: is set to `true`, the crash collector will not run on any node where a Ceph daemon runs | |||
| * `daysToRetain`: specifies the number of days to keep crash entries in the Ceph cluster. By default the entries are kept indefinitely. | |||
| * `logCollector`: The settings for log collector daemon. | |||
| * `enabled`: if set to `true`, the log collector will run as a side-car next to each Ceph daemon. The Ceph configuration option `log_to_file` will be turned on, meaning Ceph daemons will log on files in addition to still logging to container's stdout. These logs will be rotated. (default: false) | |||
| * `periodicity`: how often to rotate daemon's log. (default: 24h). Specified with a time suffix which may be 'h' for hours or 'd' for days. **Rotating too often will slightly impact the daemon's performance since the signal briefly interrupts the program.** | |||
| * `enabled`: if set to `true`, the log collector will run as a side-car next to each Ceph daemon. The Ceph configuration option `log_to_file` will be turned on, meaning Ceph daemons will log on files in addition to still logging to container's stdout. These logs will be rotated. The coredump files will be generated in `/var/lib/systemd/coredump` directory on the host depending on the underlying OS location for coredumps where the pod is running in case a daemon terminates with a segfault. (default: `true`) | |||
There was a problem hiding this comment.
Looks good, just a small suggestion
Suggested change
| * `enabled`: if set to `true`, the log collector will run as a side-car next to each Ceph daemon. The Ceph configuration option `log_to_file` will be turned on, meaning Ceph daemons will log on files in addition to still logging to container's stdout. These logs will be rotated. The coredump files will be generated in `/var/lib/systemd/coredump` directory on the host depending on the underlying OS location for coredumps where the pod is running in case a daemon terminates with a segfault. (default: `true`) | |
| * `enabled`: if set to `true`, the log collector will run as a side-car next to each Ceph daemon. The Ceph configuration option `log_to_file` will be turned on, meaning Ceph daemons will log on files in addition to still logging to container's stdout. These logs will be rotated. In case a daemon terminates with a segfault, the coredump files will be commonly be generated in `/var/lib/systemd/coredump` directory on the host, depending on the underlying OS location. (default: `true`) |
travisn
approved these changes
Oct 19, 2022
enabling logCollector by default will enable the coredump generation in case a process terminates with a segmentation fault. Signed-off-by: gauravsitlani <gauravsitlani@riseup.net>
|
@travisn sure, just added it there. Let me know if it looks good |
Looks good thanks, i'll just wait to approve after the CI finishes |
galexrt
approved these changes
Oct 19, 2022
travisn
approved these changes
Oct 19, 2022
travisn
added a commit
that referenced
this pull request
Oct 19, 2022
core: enabling logCollector by default for coredump collection (backport #11163)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gauravsitlani gauravsitlani@riseup.net
Description of your changes:
To enable log collector by default for getting coredump for troubleshooting in case of segfaults.
Which issue is resolved by this Pull Request:
Resolves #10788 #11151
Checklist:
skip-cion the PR.