build: Update the go modules to the latest #11170
Conversation
travisn
force-pushed
the
update-modules
branch
2 times, most recently
from
240b5d4
to
715261a
Compare
| @@ -256,7 +256,7 @@ func TestCommitConfigChanges(t *testing.T) { | |||
| }, | |||
| expectCommands{ | |||
| periodUpdate: true, | |||
| periodCommit: false, | |||
| periodCommit: true, | |||
There was a problem hiding this comment.
@BlaineEXE By updating to go-ceph v0.18, the period is now being committed. Does this sound expected for this test?
There was a problem hiding this comment.
I don't think that is expected. Let me pull these changes locally and poke around.
There was a problem hiding this comment.
I find it more likely that possibly go-cmp has changed from v0.5.8 to v0.5.9
There was a problem hiding this comment.
Any concern with merging this for now?
There was a problem hiding this comment.
Yes. This will mean the RGW period gets updated on every reconcile. IIRC, the behavior to commit only if changes will be made was done so as to not cause any hiccups in RGW availability unless necessary.
|
Does this process is done by |
We have a make command: |
The security scan is failing due to a go dependency so we update the go modules and all dependencies to the latest available. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
update-modules
branch
from
715261a
to
ba6adc6
Compare
build: Update the go modules to the latest (backport #11170)
Description of your changes:
The security scan is failing due to a go dependency so we update the go modules and all dependencies to the latest available.
Which issue is resolved by this Pull Request:
Resolves #11166
Checklist:
skip-cion the PR.