Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: The mon daemons maintain host network settings to allow change in config #11211

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

travisn
Copy link
Member

@travisn travisn commented Oct 25, 2022

Description of your changes:
If the host network setting is changed in the cluster CR, the existing mons must continue using the same network settings or else the operator would update their pod specs with the incorrect settings and cause mon quorum to go down. Now the network setting is preserved so the admin could switch between host and non-host network configuration without reinstalling.

Which issue is resolved by this Pull Request:
Resolves #11121

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Member

@BlaineEXE BlaineEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. It's not explicit here: does this automatically fail over mons to the newest network config, or does it still keep the mons running using the old config?

@travisn
Copy link
Member Author

travisn commented Oct 26, 2022

I think this looks good. It's not explicit here: does this automatically fail over mons to the newest network config, or does it still keep the mons running using the old config?

It won’t automatically failover the mons. I'll add a note to the cluster CR doc that the mon failover would need to be triggered to complete the conversion.

If the host network setting is changed in the cluster CR,
the existing mons must continue using the same network
settings or else the operator would update their pod
specs with the incorrect settings and cause mon quorum
to go down. Now the network setting is preserved so
the admin could switch between host and non-host network
configuration without reinstalling.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to host networking on a running cluster
2 participants