mds: support mds with multus

[subhamkrai]

to support mds with multus, we don't need
to add --public-adr, if multus is selected as
the network in cephCluster CR.

Signed-off-by: subhamkrai srai@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
• Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
• Reviewed the developer guide on Submitting a Pull Request
• Pending release notes updated with breaking and/or notable changes for the next minor release.
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.

[subhamkrai]

testing result

mdsMap

cat mdsmap 
epoch 7
root 0
max_mds 1
session_timeout 60
session_autoclose 300
        mds0    (1)192.168.20.12:6801   (up:active)

network attachment

apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"k8s.cni.cncf.io/v1","kind":"NetworkAttachmentDefinition","metadata":{"annotations":{},"labels":null,"name":"public-net","namespace":"rook-ceph"},"spec":{"config":"{ \"cniVersion\": \"0.3.0\", \"type\": \"macvlan\", \"master\": \"eth0\", \"mode\": \"bridge\", \"ipam\": { \"type\": \"whereabouts\", \"range\": \"192.168.20.0/24\" } }"}}
  creationTimestamp: "2023-02-03T03:43:20Z"
  generation: 1
  name: public-net
  namespace: rook-ceph
  resourceVersion: "1246"
  uid: 5d84b2cb-0baa-4683-9362-c46a3e23e265
spec:
  config: '{ "cniVersion": "0.3.0", "type": "macvlan", "master": "eth0", "mode": "bridge",
    "ipam": { "type": "whereabouts", "range": "192.168.20.0/24" } }'

we can see in mdsmap IP range is the same as the network attachment.

[travisn]

LGTM and the multus test passed, so the CI failures look like the known issues.

[parth-gr]

to support mds with multus, we need don't need
to add --public-adr is multus is selected as
a network in cephCluster CR network.

Can we update commit message to

to support mds with multus, we don't need
to add `--public-adr`, if multus is selected as
the network in cephCluster CR.

[parth-gr]

maybe a comment to it why the --pubic-addr is not required

[subhamkrai]

Do you want to a specific message? since I think the condition is readable but I'm happy to add some message

[parth-gr]

Yaa condition looks fine,
I mean to tell the developer why we need that

[subhamkrai]

to support mds with multus, we need don't need
to add --public-adr is multus is selected as
a network in cephCluster CR network.

Can we update commit message to

to support mds with multus, we don't need
to add `--public-adr`, if multus is selected as
the network in cephCluster CR.

updated

[BlaineEXE]

Many failing tests last run. Re-running.

[BlaineEXE]

requesting changes until CI passes

[subhamkrai]

requesting changes until CI passes

@BlaineEXE this are know ci errors, we have some issue in ci from past week or so. Discussion going on #11600