Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: suggest qemu driver for minikube on apple silicon #11722

Merged
merged 1 commit into from Jun 14, 2023

Conversation

BlaineEXE
Copy link
Member

@BlaineEXE BlaineEXE commented Feb 20, 2023

Apple silicon does not support hyperkit, and virtualbox does not support Apple silicon (yet). Suggest the QEMU driver for development on MacOS with Apple silicon.

We should wait to merge this until kubernetes/minikube#15887 is pulled and available via brew.

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@BlaineEXE BlaineEXE marked this pull request as draft February 20, 2023 18:40
@travisn travisn changed the title docs: suggest qeumu driver for minikube on apple silicon docs: suggest qemu driver for minikube on apple silicon Feb 28, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Labeled by the stale bot label Mar 31, 2023
@github-actions
Copy link

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

@github-actions github-actions bot closed this Apr 14, 2023
@BlaineEXE BlaineEXE reopened this Jun 12, 2023
@BlaineEXE BlaineEXE marked this pull request as ready for review June 12, 2023 18:10
@galexrt
Copy link
Member

galexrt commented Jun 14, 2023

@BlaineEXE could you please rebase so the CI runs again with the skip-ci label applied

Apple silicon does not support hyperkit, and virtualbox does not support
Apple silicon (yet). Suggest the QEMU driver for development on MacOS
with Apple silicon.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@BlaineEXE BlaineEXE force-pushed the update-minikube-doc-for-mac-m1 branch from 25d3380 to a57d972 Compare June 14, 2023 17:08
@BlaineEXE BlaineEXE merged commit 0363ee0 into rook:master Jun 14, 2023
17 checks passed
@BlaineEXE BlaineEXE deleted the update-minikube-doc-for-mac-m1 branch June 14, 2023 17:11
travisn added a commit that referenced this pull request Jun 15, 2023
docs: suggest qemu driver for minikube on apple silicon (backport #11722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants