Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr: revert readiness probe and go back to the original sidecar HA implementation #11829

Merged
merged 5 commits into from
Mar 7, 2023
Merged

mgr: revert readiness probe and go back to the original sidecar HA implementation #11829

merged 5 commits into from
Mar 7, 2023

Conversation

rkachach
Copy link
Contributor

@rkachach rkachach commented Mar 3, 2023 •
edited

Description of your changes:

Revert all the commits related to the readiness probe

Which issue is resolved by this Pull Request:
Resolves #11791
Closes: #11791

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@rkachach rkachach changed the title [WIP] [DNM] Fix issue 11791 [WIP] [DNM] revert readiness probe and use dynamic active label to implement the mgr HA Mar 3, 2023
@mergify
Copy link

mergify bot commented Mar 3, 2023

This pull request has merge conflicts that must be resolved before it can be merged. @rkachach please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

@rkachach rkachach changed the title [WIP] [DNM] revert readiness probe and use dynamic active label to implement the mgr HA revert readiness probe and go back to the original sidecar HA implementation Mar 7, 2023
@rkachach rkachach changed the title revert readiness probe and go back to the original sidecar HA implementation mgr: revert readiness probe and go back to the original sidecar HA implementation Mar 7, 2023
@rkachach rkachach requested a review from travisn March 7, 2023 08:41
@rkachach rkachach marked this pull request as ready for review March 7, 2023 08:51
@rkachach
Revert "mgr: wait for the mgr pod to be running"
c318320 
This reverts commit 4d1017f.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@rkachach
Revert "ci: fix MultiClusterDeploySuite CI"
0c652d2 
This reverts commit b464428.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@rkachach
Revert "mgr: addressing review comments"
adc79d4 
This reverts commit 9f37439.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@rkachach
Revert "mgr: remove mgr sidecar"
456a0c3 
This reverts commit ff75ec9.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@rkachach
Revert "mgr: use k8s readiness probe to implement mgr HA"
0ae7867 
This reverts commit dc76f81.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
travisn
travisn approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My testing of these changes looks good, as discussed let's go ahead and revert, and follow up in a future PR with a new solution.

@travisn travisn merged commit 0a7c3c1 into rook:master Mar 7, 2023
@mergify mergify bot mentioned this pull request Mar 7, 2023
Merged
travisn added a commit that referenced this pull request Mar 7, 2023
@travisn
Merge pull request #11847 from rook/mergify/bp/release-1.11/pr-11829
b264d9d 
mgr: revert readiness probe and go back to the original sidecar HA implementation (backport #11829)
@rkachach rkachach mentioned this pull request Mar 8, 2023
Closed
@uhthomas uhthomas mentioned this pull request Mar 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
backport-release-1.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.11.x readiness probe change causes prometheus alerts
2 participants
@rkachach @travisn