external: pool and metadata ec pools were reversed in scripts

[dragon2611]

Pool and Metadata Pool Appear to be reversed causing PVC creation to fail

Description of your changes:
It seems the data-pool and EC pool on an external cluster are set the wrong way round in the example code for configuring external clusters

dataPool: needs to contain the EC Data pool
pool: needs to contain the Metadata Pool

Which issue is resolved by this Pull Request:
Resolves
#11918

[travisn]

The changes look good, thanks for the contribution. It appears nobody used the EC pools before for the external clusters.

To make the commitlint bot happy, try the following as a commit title:

external: pool and metadata ec pools were reversed in scripts

[dragon2611]

Not sure that should have really been a force push on my repo, but I did a git commit --amend to change the commit message, hopefully the bot is happier now.

[travisn]

Not sure that should have really been a force push on my repo, but I did a git commit --amend to change the commit message, hopefully the bot is happier now.

Looks good now, thanks. Actually the force push is recommended, see our dev guide for future reference.

[travisn]

Just waiting for the CI now to merge...

[travisn]

Oh, I overlooked that the DCO check is failing. See the dev guide on the expected signature in the commit message, thanks.

[dragon2611]

Hopefully it's happier now.

[dragon2611]

@travisn seems the DCO check is still not happy?
Only thing I can think of is that email doesn't match the github account that it thinks made the commit (which it seems to have taken from one of my SSH public keys)

[travisn]

@travisn seems the DCO check is still not happy? Only thing I can think of is that email doesn't match the github account that it thinks made the commit (which it seems to have taken from one of my SSH public keys)

It looks like the right format, i'm not sure it validates the email anyway. On occasion it's not clear what it's being picky about, so I set it to ignore for this commit.

[parth-gr]

So @travisn @dragon2611 we also need similar change here?

rook/deploy/examples/csi/rbd/storageclass-ec.yaml

Line 45 in 44d58ef

dataPool: ec-data-pool

[dragon2611]

@parth-gr That looks ok to me, it seems when using a standard replicated pool you just need pool but for EC you need a standard replicated pool for the metadata and then the EC pool for the data.

dataPool: Should be the EC pool
pool: Should be the replicated metadata pool

[parth-gr]

agree thanks