mgr: failed to update the port of dashboard #11932
Conversation
zhucan
changed the title
|
releated qa: #11916 (comment) |
There was a problem hiding this comment.
@zhucan can you explain more about the changes in pr description? Thanks!
Please take a look at the https://github.com/rook/rook/issues/11931， because of firstly we use the port 443 or 6443, but it was used by other daemon，the dashboard will start failed and the status of the ceph will be err，then we update the port to a unused port，the operator can not deal with it. |
|
@zhucan Please also fill in the PR description section: |
|
@travisn done |
| @@ -104,7 +100,13 @@ func (c *Cluster) configureDashboardModules() error { | |||
| } | |||
| if hasChanged { | |||
| logger.Info("dashboard config has changed. restarting the dashboard module") | |||
| return c.restartDashboard() | |||
| if err := c.restartDashboard(); err != nil { | |||
There was a problem hiding this comment.
Don't we need to restart the dashboard after the ssl cert is generated? Now we won't restart the dashboard if the ssl setting changes, won't that be a problem? Perhaps we need another dashboard restart inside initializeSecureDashboard() in that case.
There was a problem hiding this comment.
There was a problem hiding this comment.
other question is: after the ssl cert is generated, need to restart dashboard? we had tested with this case? may need to test the case.
There was a problem hiding this comment.
@travisn please take a look at it
There was a problem hiding this comment.
I see that the helper was always returning false, but the intention was that the dashboard should be restarted in case the ssl cert was generated. @jmolmo Does this sound correct, or do we not need to restart the dashboard module after creating the self signed cert?
| @@ -104,7 +100,13 @@ func (c *Cluster) configureDashboardModules() error { | |||
| } | |||
| if hasChanged { | |||
| logger.Info("dashboard config has changed. restarting the dashboard module") | |||
| return c.restartDashboard() | |||
| if err := c.restartDashboard(); err != nil { | |||
There was a problem hiding this comment.
I see that the helper was always returning false, but the intention was that the dashboard should be restarted in case the ssl cert was generated. @jmolmo Does this sound correct, or do we not need to restart the dashboard module after creating the self signed cert?
|
This pull request has merge conflicts that must be resolved before it can be merged. @zhucan please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork |
zhucan
force-pushed
the
fix-11931
branch
3 times, most recently
from
f4d3a0d
to
3cb8433
Compare
There was a problem hiding this comment.
Also please add one or two sentences to the commit description, which will help understand the changes in the git history. See the commit structure guide.
if port was used by other daemon，the dashboard will start failed and the status of the ceph will be err，then we update the port to a unused port，the operator can not deal with it Signed-off-by: zc <zc@zcdeMacBook-Pro.local>
|
@travisn please take a look |
mgr: failed to update the port of dashboard (backport #11932)
Description of your changes:
Firstly we use the port 443 or 6443 to mgr dashboard, but it was used by other daemon; The dashboard will start failed and the status of the ceph will be HEALTH_ERR; then we update the port to a unused port，the operator can not deal with it. after this change, dashboard can start normally and the status of ceph will be HEALTH_OK.
Which issue is resolved by this Pull Request:
Resolves #11931
Checklist:
skip-cion the PR.