Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi: IPv6 compatibility for requiring msgr2 #11992

Merged
merged 1 commit into from
Mar 29, 2023
Merged

csi: IPv6 compatibility for requiring msgr2 #11992

merged 1 commit into from
Mar 29, 2023

Conversation

travisn
Copy link
Member

@travisn travisn commented Mar 28, 2023 •
edited

Description of your changes:
The msgr2 conversion assumed the endpoints were formatted with a single :, which is not compatible with ipv6. Now if the endpoint ends with the v1 port, it will simply update the prefix to v2.

Which issue is resolved by this Pull Request:
Related to: #11977

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@travisn
csi: ipv6 compatibility for requiring msgr2
bbfba54 
The msgr2 conversion assumed the endpoints were formatted
with a single :, which is not compatible with ipv6.
Now if the endpoint ends with the v1 port, it will
simply update the prefix to v2.

Signed-off-by: travisn <tnielsen@redhat.com>
@travisn travisn requested a review from sp98 March 28, 2023 21:14
@travisn travisn mentioned this pull request Mar 28, 2023
Closed
@travisn travisn merged commit 305aae5 into rook:master Mar 29, 2023
1 check passed
@mergify mergify bot mentioned this pull request Mar 29, 2023
Merged
travisn added a commit that referenced this pull request Mar 29, 2023
@travisn
Merge pull request #12001 from rook/mergify/bp/release-1.11/pr-11992
c8b2b96 
csi: IPv6 compatibility for requiring msgr2 (backport #11992)
@travisn travisn deleted the ipv6-msgr2 branch December 13, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sp98 sp98 sp98 approved these changes

Assignees
No one assigned
Labels
backport-release-1.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travisn @sp98