Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external: do not enforce rbd, cephfs and rgw flags for the external cluster #12028

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

parth-gr
Copy link
Member

@parth-gr parth-gr commented Apr 4, 2023

there might be a user who only wants to use rbd, so don't enforce them
to to create all the pools and pass the flags

Closes: #11846

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a brief description paragraph in the commit message and the PR description that describes more the changes.

…luster

there might be a user who only wants to use rbd, so don't enforce them
to to create all the pools and pass the flags

Closes: rook#11846
Signed-off-by: parth-gr <paarora@redhat.com>
@parth-gr parth-gr changed the title external: do not enforce cephfs ad rgw flags for the external cluster external: do not enforce rbd, cephfs and rgw flags for the external cluster Apr 5, 2023
@parth-gr parth-gr requested a review from travisn April 5, 2023 11:53
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see the CI is passing for the external tests, but before we merge, can you comment on how you could test the changes?

@parth-gr
Copy link
Member Author

parth-gr commented Apr 5, 2023

LGTM. I see the CI is passing for the external tests, but before we merge, can you comment on how you could test the changes?

Basically, run the script on any rook cluster,
And check if we don't give cephfs for example then it won't complain for it and would be succeeded

@parth-gr
Copy link
Member Author

parth-gr commented Apr 6, 2023

Tested,
It worked

[rider@localhost ~]$ ./a.sh
secret/rook-ceph-mon created
configmap/rook-ceph-mon-endpoints created
secret/rook-csi-rbd-node created
secret/rook-csi-rbd-provisioner created
storageclass.storage.k8s.io/ceph-rbd created

@travisn travisn merged commit 36138fc into rook:master Apr 6, 2023
47 of 50 checks passed
travisn added a commit that referenced this pull request Apr 11, 2023
external: do not enforce rbd, cephfs and rgw flags for the external cluster (backport #12028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import-external-cluster.sh errors
3 participants