helm: add option to scale down rook operator #12048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please backport this to 1.11 |
TomHellier
force-pushed
the
master
branch
2 times, most recently
from
9e75f0b
to
ad9f571
Compare
travisn
requested changes
Apr 7, 2023
deploy/charts/rook-ceph/values.yaml
Outdated
| @@ -567,6 +567,11 @@ cephCommandsTimeoutSeconds: "15" | |||
| # -- if true, run rook operator on the host network | |||
| useOperatorHostNetwork: | |||
|
|
|||
| # -- if true, scale down the rook operator | |||
There was a problem hiding this comment.
nit: The generated doc doesn't read smoothly without a new sentence.
Suggested change
| # -- if true, scale down the rook operator | |
| # -- If true, scale down the rook operator. |
There was a problem hiding this comment.
Thanks @travisn - I've applied this fix
Some administrative actions require the user to scale down the rook operator to zero replicas to stop any potential conflicts where the operator is attempting to do something contrary to the current goals of the administrator. closes: rook#11927 Signed-off-by: TomHellier <me@tomhellier.com>
travisn
approved these changes
Apr 10, 2023
travisn
added a commit
that referenced
this pull request
Apr 11, 2023
helm: add option to scale down rook operator (backport #12048)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Some administrative actions require the user to scale down the rook operator to zero replicas to stop any potential conflicts where the operator is attempting to do something contrary to the current goals of the administrator.
Which issue is resolved by this Pull Request:
Addresses #11927
Checklist:
skip-cion the PR.