helm: drop snapshot.storage.k8s.io/v1beta1

[sathieu]

Description of your changes:

drop snapshot.storage.k8s.io/v1beta1, v1 exists since k8s v1.20.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
• Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
• Reviewed the developer guide on Submitting a Pull Request
• Pending release notes updated with breaking and/or notable changes for the next minor release.
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.

[sathieu]

I had a problem with ArgoCD, where rook-ceph was installed (or at leased evaluated) before csi-snapshotter CRDs were installed.

Message is: no matches for kind "VolumeSnapshotClass" in version "snapshot.storage.k8s.io/v1beta1".

(From: https://gitlab.com/kubitus-project/kubitus-installer/-/jobs/4082126134/artifacts/external_file/kubectl_describe_applications.log
https://gitlab.com/kubitus-project/kubitus-installer/-/jobs/4082126134, from https://gitlab.com/kubitus-project/kubitus-installer/-/merge_requests/1214)

[travisn]

The change looks good to me since K8s 1.21+ is required for Rook v1.11, just one question before merging...

I had a problem with ArgoCD, where rook-ceph was installed (or at leased evaluated) before csi-snapshotter CRDs were installed.

@sathieu Are you saying this was a different problem, or because of these v1beta1 obsolete CRDs?

[sathieu]

@travisn

@sathieu Are you saying this was a different problem, or because of these v1beta1 obsolete CRDs?

This is the problem which leads me to create this PR.

ArgoCD uses helm template and passes available APIs using the --api-versions flag. This helm template command is only run once for a given Git commit (unless "force-refresh" is done). If the snapshot CRDs are not available when helm template is run, the chart will default to CRDs "beta1". ArgoCD will not regenerate the resources, and those will fail to apply, even if snapshot CRDs are available later.

My PR simply removes snapshot v1beta1 CRDs, because they are very old (1.17 <= K8s <= v1.19).