core: temporary disable exporter service #12118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanthakkar
force-pushed
the
fix-exporter-service
branch
from
3d98097
to
8ac79fb
Compare
galexrt
requested changes
Apr 20, 2023
| if _, err := k8sutil.CreateOrUpdateService(r.opManagerContext, r.context.Clientset, cephCluster.Namespace, service); err != nil { | ||
| return errors.Wrap(err, "failed to create ceph-exporter metrics service") | ||
| } | ||
| if cephVersion.IsAtLeast(cephver.CephVersion{Major: 18, Minor: 0, Extra: 0}) { |
There was a problem hiding this comment.
Let's add a short comment on "why" Ceph version 18 is required here
There was a problem hiding this comment.
Since this version is used in two places, let's create a package var for it, and then add the comment there about the reason.
There was a problem hiding this comment.
Added a MinVersionForCephExporter var
parth-gr
reviewed
Apr 20, 2023
| if cephVersion.IsAtLeast(cephver.CephVersion{Major: 18, Minor: 0, Extra: 0}) { | ||
| logger.Debugf("ceph exporter successfully reconciled for node %q. operation: %q", node.Name, op) | ||
| // create the metrics service | ||
| service, err := MakeCephExporterMetricsService(cephCluster, exporterServiceMetricName, r.scheme) |
There was a problem hiding this comment.
PLease update the PR description,
And also the PR tracker link where you disabled exporter pods.
Create the exporter service only if exporter pods are created. Signed-off-by: avanthakkar <avanjohn@gmail.com>
avanthakkar
force-pushed
the
fix-exporter-service
branch
from
8ac79fb
to
32b2445
Compare
galexrt
approved these changes
Apr 21, 2023
|
I tested these changes on ocp and it is working
we can see no svc was created and all the ceph daemons are created successfully. |
subhamkrai
changed the title
parth-gr
approved these changes
Apr 21, 2023
travisn
added a commit
that referenced
this pull request
Apr 24, 2023
core: temporary disable exporter service (backport #12118)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exporter service should only be created if exporter pods are created. Recently the creation was disabled temporarily due to some regression detected in Ceph v17.2.6 #12077
Signed-off-by: avanthakkar avanjohn@gmail.com
Description of your changes:
Create the exporter service only if exporter pods are created.
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-cion the PR.