doc: add the table to know supported osd configuration #12166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
|
@satoru-takeuchi what's the status of this? |
|
I'll try this after merging #12165 . |
|
It's better to describe only |
7 tasks
satoru-takeuchi
force-pushed
the
doc-add-table-to-know-supported-osd-configuration
branch
from
72f7dbd
to
2f3e682
Compare
travisn
requested changes
Oct 24, 2023
satoru-takeuchi
force-pushed
the
doc-add-table-to-know-supported-osd-configuration
branch
2 times, most recently
from
b8587ed
to
ea282f3
Compare
satoru-takeuchi
force-pushed
the
doc-add-table-to-know-supported-osd-configuration
branch
from
ea282f3
to
b049fb1
Compare
travisn
requested changes
Oct 25, 2023
| @@ -421,7 +421,7 @@ Below are the settings for host-based cluster. This type of cluster can specify | |||
| * `name`: The name of the devices and partitions (e.g., `sda`). The full udev path can also be specified for devices, partitions, and logical volumes (e.g. `/dev/disk/by-id/ata-ST4000DM004-XXXX` - this will not change after reboots). | |||
| * `config`: Device-specific config settings. See the [config settings](#osd-configuration-settings) below | |||
|
|
|||
| Host-based cluster supports raw device, partition, and logical volume. Be sure to see the | |||
| Host-based cluster supports raw device, partition, logical volume, encrypted device, and multiple device. Be sure to see the | |||
There was a problem hiding this comment.
Did you intend multipath?
Suggested change
| Host-based cluster supports raw device, partition, logical volume, encrypted device, and multiple device. Be sure to see the | |
| Host-based cluster supports raw devices, partitions, logical volumes, encrypted devices, and multipath devices. Be sure to see the |
There was a problem hiding this comment.
Oops, sorry. Fixed.
It's convenient to visualize the supported OSD configurations. In addition, remove the reference to the common issue section about OSD on LV-backed PVC because this issue doesn't happen anymore for new OSDs. Closes: rook#10859 Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
satoru-takeuchi
force-pushed
the
doc-add-table-to-know-supported-osd-configuration
branch
from
b049fb1
to
bab6e01
Compare
travisn
approved these changes
Oct 25, 2023
satoru-takeuchi
added a commit
that referenced
this pull request
Oct 25, 2023
doc: add the table to know supported osd configuration (backport #12166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
It's convenient to know the supported OSD configuration in a table.
Which issue is resolved by this Pull Request:
Resolves #10859
Checklist:
skip-cion the PR.