servicemonitor for rook-ceph csi drivers #12170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
May 2, 2023
travisn
requested changes
May 4, 2023
There was a problem hiding this comment.
Please update the commits:
- Squash the commits
- Add a description paragraph to the commit message as described in the developer guide
the ServiceMonitor depends on: * monitoring.enabled (availability of prometheus-operator) * csi.serviceMonitor.enabled, to create the ServiceMonitor * csi.enableGrpcMetrics and csi.enableLiveness to enable their respective endpoints in the ServiceMonitor Signed-off-by: Cyril Jouve <jv.cyril@gmail.com>
|
commits squashed and updated. thanks for the review :) |
galexrt
approved these changes
May 8, 2023
travisn
approved these changes
May 8, 2023
travisn
added a commit
that referenced
this pull request
May 8, 2023
servicemonitor for rook-ceph csi drivers (backport #12170)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
implement https://github.com/rook/rook/blob/master/deploy/examples/monitoring/csi-metrics-service-monitor.yaml in the helm chart
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-cion the PR.