Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: disable controller runtime metrics server #12194

Merged
merged 1 commit into from
May 5, 2023

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented May 5, 2023

Description of your changes:

As we are not using the controller runtime metrics we dont even need to start the server as it just uses extra resources and its not much useful.

  • Before disabling the metrics port
sh-4.4# netstat -plnt
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name    
tcp6       0      0 :::8080                 :::*                    LISTEN      1/rook              
sh-4.4# 
  • After Disabling the metrics port
sh-4.4# netstat -plnt
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name    
sh-4.4# 

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

As we are not using the controller runtime
metrics we dont even need to start the server
as its just uses extra resouces and its not
much useful.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@travisn travisn merged commit c79f100 into rook:master May 5, 2023
49 of 50 checks passed
travisn added a commit that referenced this pull request May 5, 2023
core: disable controller runtime metrics server (backport #12194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants