helm: add exporter resource entry to ceph cluster #12251
Conversation
|
To ask @travisn question from the other PR here, @avanthakkar do you have an idea about the memory/cpu the exporter would be expected to consume? |
I don't have the exact data with me currently, but i think 1Gi is good to have, same as it's been in cephadm. And for cpu I'm not really sure, but will check, probably should be same as |
| exporter: | ||
| limits: | ||
| cpu: "300m" | ||
| memory: "512Mi" |
There was a problem hiding this comment.
Per discussion in huddle, how much memory are you seeing used in practice? Even 512Mi seems like a high limit.
| @@ -542,6 +543,7 @@ If a user configures a limit or request value that is too low, Rook will still r | |||
| * `crashcollector`: 60MB | |||
| * `mgr-sidecar`: 100MB limit, 40MB requests | |||
| * `prepareosd`: no limits (see the note) | |||
| * `exporter`: 512MB | |||
There was a problem hiding this comment.
This list is more of a recommended limit, rather than an upper limit. So based on your testing, hopefully we can lower this recommended limit maybe to 256 or even 128Mi
galexrt
force-pushed
the
pickup_pr_11914
branch
2 times, most recently
from
e25001c
to
6c7a8f2
Compare
| @@ -540,6 +541,7 @@ If a user configures a limit or request value that is too low, Rook will still r | |||
| * `crashcollector`: 60MB | |||
| * `mgr-sidecar`: 100MB limit, 40MB requests | |||
| * `prepareosd`: no limits (see the note) | |||
| * `exporter`: 128MB | |||
There was a problem hiding this comment.
@avanthakkar Can you add your findings here for the memory/cpu requirements? In our offline conversation, sounds like it was much lower than this.
There was a problem hiding this comment.
@avanthakkar do you think 128MB is too much or okay for the exporter on each node?
This adds the new `exporter:` resource key to the Ceph cluster example yaml. It also set some sane resource requests and limits for it in the CephCluster section of the rook-ceph Helm chart. Closes rook#11914 Signed-off-by: Alexander Trost <galexrt@googlemail.com>
helm: add exporter resource entry to ceph cluster (backport #12251)
Description of your changes:
This adds the new
exporter:resource key to the Ceph cluster example yaml. It also set some sane resource requests and limits for it in the CephCluster section of the rook-ceph Helm chart.Which issue is resolved by this Pull Request:
Closes #11914
Checklist:
skip-cion the PR.