-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
object: add missing cephcluster spec addition in object controller #12273
Conversation
22cf72e
to
638a44a
Compare
I think it's appropriate to squash these commits together, and also make sure there is a sentence that says why the ceph cluster is removed -- what is removed and no longer needed in the second commit. Otherwise, I think this looks good 👍 thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, since this is more about the object controller than the RGW itself, let's use object: ...
for the commit and PR title rather than rgw: ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, since this is more about the object controller than the RGW itself, let's use object: ...
for the commit and PR title rather than rgw: ...
80fa9f3
to
0f0f7cb
Compare
@thotz Please take care of the commitlint error as well |
c1b9afd
to
70b6aff
Compare
Sorry I tried all the possibilities which I can I don't understand what they meant by
I have given blank line after Signed-off-by: still its complaining the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding, commitlint, try remove #
from the description. see if that helps
…dmin The radosgw-admin command uses the network spec from ceph cluster spec in object context but it is not filled properly in the object package. But with PR 10898, network spec is available in clusterinfo which can be used directly. Also removed cluserspec from object context. Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
70b6aff
to
1f45cfa
Compare
Thanks it worked |
@@ -214,7 +213,7 @@ func RunAdminCommandNoMultisite(c *Context, expectJSON bool, args ...string) (st | |||
var err error | |||
|
|||
// If Multus is enabled we proxy all the command to the mgr sidecar | |||
if c.CephClusterSpec.Network.IsMultus() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this was not working?
Hope you have tested the changes by creating the buckets claims and checked every thing works fine....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some parts of the code, object context was not set with clusterspec, we already had the Network info in clusterinfo. Hence changed this check instead of filling clusterspec to object context
object: add missing cephcluster spec addition in object controller (backport #12273)
Description of your changes:
The ceph cluster spec need to set on object context for executing radosgw-admin commands if multus is enabled.
The radosgw-admin command uses the network spec from ceph cluster spec
in object context but it is not filled properly in the object package.
But with PR 10898, network spec is available in clusterinfo which can
be used directly. Also removed cluserspec from object context.
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-ci
on the PR.