Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: use -default-* flags #12302

Merged
merged 1 commit into from
May 30, 2023
Merged

core: use -default-* flags #12302

merged 1 commit into from
May 30, 2023

Conversation

Javlopez
Copy link
Contributor

@Javlopez Javlopez commented May 30, 2023 •
edited

enable flags with --default prefix for --log-to-stderr, --mon-cluster-log-to-stderr, --err-to-stderr, and --log-stderr-prefix

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #11429

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@Javlopez
core: use -default-* flags
02e1719 
enable flags with --default prefix for --log-to-stderr, --mon-cluster-log-to-stderr, --err-to-stderr, and --log-stderr-prefix

Signed-off-by: Javier <sjavierlopez@gmail.com>
@Javlopez Javlopez mentioned this pull request May 30, 2023
Closed
7 tasks
@Javlopez Javlopez added the logs logging label May 30, 2023
@Javlopez Javlopez self-assigned this May 30, 2023
@travisn travisn merged commit 351751a into rook:master May 30, 2023
49 of 50 checks passed
@mergify mergify bot mentioned this pull request May 30, 2023
Merged
travisn added a commit that referenced this pull request May 30, 2023
@travisn
Merge pull request #12303 from rook/mergify/bp/release-1.11/pr-12302
04e2137 
core: use -default-* flags (backport #12302)
@Javlopez Javlopez deleted the feature/11429-use-default-for-logging-to-stderr branch February 9, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@BlaineEXE BlaineEXE Awaiting requested review from BlaineEXE

Assignees

@Javlopez Javlopez

Labels
backport-release-1.11 logs logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use --default-* flags for logging to stderr
2 participants
@Javlopez @travisn