Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr: removing unnecessary rook-ceph-mgr rbac entries #12337

Merged
merged 1 commit into from Jun 6, 2023
Merged

mgr: removing unnecessary rook-ceph-mgr rbac entries #12337

merged 1 commit into from Jun 6, 2023

Conversation

rkachach
Copy link
Contributor

@rkachach rkachach commented Jun 6, 2023

Closes: #12336

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@rkachach rkachach self-assigned this Jun 6, 2023
@rkachach rkachach requested a review from travisn June 6, 2023 13:03
travisn
travisn requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, please just add a brief commit description paragraph as described in the development guide. Thanks!

@rkachach
mgr: removing unnecessary rook-ceph-mgr rbac entries
08754f6 
These rbac changes were introduced as part of rook#11845 PR to enable
sidecar accessing mgr pods but in fact they are not necessary
as rook-ceph-mgr role had already the ability to update pods

Closes: rook#12336

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@rkachach rkachach requested a review from travisn June 6, 2023 20:19
@rkachach
Copy link
Contributor Author

rkachach commented Jun 6, 2023

The change looks good, please just add a brief commit description paragraph as described in the development guide. Thanks!

Sure. I updated the commit message.

@travisn travisn merged commit 747fe82 into rook:master Jun 6, 2023
48 of 50 checks passed
@mergify mergify bot mentioned this pull request Jun 6, 2023
Merged
travisn added a commit that referenced this pull request Jun 8, 2023
@travisn
Merge pull request #12339 from rook/mergify/bp/release-1.11/pr-12337
3c45fba 
mgr: removing unnecessary rook-ceph-mgr rbac entries (backport #12337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@galexrt galexrt galexrt approved these changes

Assignees

@rkachach rkachach

Labels
backport-release-1.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary entries in rook-ceph-mgr rbac
3 participants
@rkachach @travisn @galexrt