-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated annotation #12418
Remove deprecated annotation #12418
Conversation
There are a couple more places to update this example as well:
Also, see the recommendation on commit structure so the Commitlint bot will be happy. A prefix of Thanks! |
Hm... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm...
deploy/charts/rook-ceph-cluster/values.yaml
looks fine to me.
It's in a commented example here, just not created by default.
Also, see the recommendation on commit structure so the Commitlint bot will be happy. A prefix of docs: will work.
Instead of doc:
, use docs:
. Also as described in that link if you could add a brief description paragraph, thanks
@travisn You are a rigid teacher! And yes,I know, I am lazy - by profession. I wonder why I've overseen the one occurrence in the comment. Actually I did a search for it ... I blame everyone else who distracted me ;-) |
Thanks for the entertainment, we are all distracted in some way. :) The commitlint bot is just a bit picky... ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case] |
Documentation and examples used a deprecated annotation to set the Ingress class name. This commit replaces it with the correct version using spec.ingressClassName . Signed-off-by: Marcel Lautenbach <mlautenb@gmail.com>
Remove deprecated annotation (backport #12418)
Description of your changes:
Minor update in Documentation. The ingress dashboard example used an deprecated annotation.
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-ci
on the PR.