Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated annotation #12418

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Remove deprecated annotation #12418

merged 1 commit into from
Jun 29, 2023

Conversation

Jeansen
Copy link
Contributor

@Jeansen Jeansen commented Jun 22, 2023

Description of your changes:
Minor update in Documentation. The ingress dashboard example used an deprecated annotation.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@travisn
Copy link
Member

travisn commented Jun 22, 2023

There are a couple more places to update this example as well:

  • deploy/examples/dashboard-ingress-https.yaml
  • deploy/charts/rook-ceph-cluster/values.yaml

Also, see the recommendation on commit structure so the Commitlint bot will be happy. A prefix of docs: will work.

Thanks!

@Jeansen
Copy link
Contributor Author

Jeansen commented Jun 23, 2023

Hm...deploy/charts/rook-ceph-cluster/values.yaml looks fine to me.

Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm...deploy/charts/rook-ceph-cluster/values.yaml looks fine to me.

It's in a commented example here, just not created by default.

Also, see the recommendation on commit structure so the Commitlint bot will be happy. A prefix of docs: will work.

Instead of doc:, use docs:. Also as described in that link if you could add a brief description paragraph, thanks

@Jeansen
Copy link
Contributor Author

Jeansen commented Jun 23, 2023

@travisn You are a rigid teacher! And yes,I know, I am lazy - by profession. I wonder why I've overseen the one occurrence in the comment. Actually I did a search for it ... I blame everyone else who distracted me ;-)
I hope now all is to your satisfaction?

@travisn
Copy link
Member

travisn commented Jun 23, 2023

@travisn You are a rigid teacher! And yes,I know, I am lazy - by profession. I wonder why I've overseen the one occurrence in the comment. Actually I did a search for it ... I blame everyone else who distracted me ;-) I hope now all is to your satisfaction?

Thanks for the entertainment, we are all distracted in some way. :)

The commitlint bot is just a bit picky...

✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖ subject may not end with full stop [subject-full-stop]

Documentation and examples used a deprecated annotation to set the Ingress class name. This commit replaces it with the correct version using spec.ingressClassName .

Signed-off-by: Marcel Lautenbach <mlautenb@gmail.com>
@travisn travisn merged commit 58994fe into rook:master Jun 29, 2023
46 of 49 checks passed
travisn added a commit that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants