Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object: align spelling of user admin capabilities with ceph #12460

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

pgoron
Copy link

@pgoron pgoron commented Jul 1, 2023

Description of your changes:
users & buckets admin capabilities aren't spelled the same
way between rook crd (singular) and ceph (plural). It's a bit
misleading when comparing ceph admin caps and rook users.

See https://github.com/ceph/ceph/blob/main/src/rgw/rgw_common.cc#L2095

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

users & buckets admin capabilities aren't spelled the same
way between rook crd (singular) and ceph (plural). It's a bit
misleading when comparing ceph admin cap and rook users.

Signed-off-by: Peter Goron <peter.goron@gmail.com>
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd to have both singular and plural, but better to have the backward compatibility than remove the singular.
@thotz Please also review

@travisn travisn requested a review from thotz July 5, 2023 22:51
@travisn travisn merged commit 2e7f904 into rook:master Jul 18, 2023
46 of 49 checks passed
travisn added a commit that referenced this pull request Jul 18, 2023
object: align spelling of user admin capabilities with ceph (backport #12460)
travisn added a commit that referenced this pull request Jul 18, 2023
object: align spelling of user admin capabilities with ceph (backport #12460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants