Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix ci test encryption-pvc-kms-vault-token-auth #12467

Merged
merged 1 commit into from
Jul 5, 2023
Merged

ci: fix ci test encryption-pvc-kms-vault-token-auth #12467

merged 1 commit into from
Jul 5, 2023

Conversation

subhamkrai
Copy link
Contributor

we need to wait for the rgw pod to be delete and not only the cephobjectsore, sometime the pod could be in terminating state. Also, in some place it require proper command to wait for pod to be ready/delete and get the pod name only.

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@subhamkrai
ci: fix ci test encryption-pvc-kms-vault-token-auth
70f29be 
we need to wait for the rgw pod to be delete and not
only the cephobjectsore, sometime the pod could be in
terminating state. Also, in some place it require proper
command to wait for pod to be ready/delete and get the
pod name only.

Signed-off-by: subhamkrai <srai@redhat.com>
@subhamkrai
Copy link
Contributor Author

I noticed in many ci errors kms-vault-token-auth was very frequent. So, raised the pr not sure if there is an issue for the ci.

parth-gr
parth-gr approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@parth-gr parth-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing:)

travisn
travisn approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for the CI fix!

@travisn travisn merged commit 063087d into rook:master Jul 5, 2023
48 of 49 checks passed
@mergify mergify bot mentioned this pull request Jul 5, 2023
Merged
travisn added a commit that referenced this pull request Jul 5, 2023
@travisn
Merge pull request #12469 from rook/mergify/bp/release-1.11/pr-12467
f08d331 
ci: fix ci test encryption-pvc-kms-vault-token-auth (backport #12467)
@subhamkrai subhamkrai deleted the fix-kms-ci branch July 5, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@parth-gr parth-gr parth-gr approved these changes

@thotz thotz Awaiting requested review from thotz

@BlaineEXE BlaineEXE Awaiting requested review from BlaineEXE

Assignees
No one assigned
Labels
backport-release-1.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@subhamkrai @travisn @parth-gr