-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osd: use cp -a command for copying init-containers binary #12501
Conversation
834111d
to
d8d21a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BlaineEXE Do you recall why we implemented the copy-binaries
command instead of using cp
like this?
I don't recall why I implemented it as a daemon. It used to copy |
This is not urgent, so I will wait for @travisn to get back from vacation. I think it may make sense to merge this into master and not backport it so that we have some time to make sure it does not negatively affect anything in master. I don't anticipate any issues, but there is always a small chance. |
d8d21a8
to
f6e6cf9
Compare
remove copy-binaries cmd and related code Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
f6e6cf9
to
d86fa2a
Compare
No code change done, forced pushed to rerun all failing test case. |
osd: use cp -a command for copying init-containers binary (backport #12501)
remove copy-binaries cmd and related code
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #5296
Checklist:
skip-ci
on the PR.