helm: additional ServiceMonitor labels #12605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
Jul 27, 2023
There was a problem hiding this comment.
The changes look good, could you just add a commit description to describe a bit more about the change?
|
Thank you! |
add a value in rook-ceph chart to add additional labels to the generated ServiceMonitor when monitoring is enabled Signed-off-by: Cyril Jouve <jv.cyril@gmail.com>
|
I added the "Description of your changes" to the commit message |
travisn
approved these changes
Aug 3, 2023
travisn
added a commit
that referenced
this pull request
Aug 4, 2023
helm: additional ServiceMonitor labels (backport #12605)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
add a values in rook-ceph to add additional labels to the generated ServiceMonitor
Which issue is resolved by this Pull Request:
Resolves #12438
Checklist:
skip-cion the PR.