multus: revise kube config/client loading #12611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
approved these changes
Jul 27, 2023
BlaineEXE
force-pushed
the
multus-revise-client-loading
branch
from
23b9346
to
2fe7ee7
Compare
The previous client loader routine assumed KUBECONFIG would be set in CLI environments. Instead, now take this approach: 1. If KUBECONFIG is set, that is the de-facto override that informs the tool it is being run in a CLI environment. 2. Otherwise, try creating a client from the default kube config file. 3. If that fails, assume the tool is running in a Kubernetes Pod. This will continue supporting dev/test environments so that building the rook container is not necessary for development. It also allows support for highly opinionated environments (like deployed by OpenShift CSVs) where it's not possible to install the Rook operator without also deploying a CephCluster. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
BlaineEXE
force-pushed
the
multus-revise-client-loading
branch
from
2fe7ee7
to
cc9514a
Compare
BlaineEXE
added a commit
that referenced
this pull request
Jul 28, 2023
multus: revise kube config/client loading (backport #12611)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous client loader routine assumed KUBECONFIG would be set in CLI environments. Instead, now take this approach:
This will continue supporting dev/test environments so that building the rook container is not necessary for development. It also allows support for highly opinionated environments (like deployed by OpenShift CSVs) where it's not possible to install the Rook operator without also deploying a CephCluster.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #12603
Checklist:
skip-cion the PR.