docs: add note in upgrade guide about cephfs driver's breaking change #12615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
Jul 28, 2023
| @@ -49,6 +49,9 @@ those releases. | |||
| ## Breaking changes in v1.12 | |||
|
|
|||
| * The minimum supported version of Kubernetes is v1.22. | |||
| * CephCSI CephFS driver introduced a breaking change in v3.9.0. Please follow the steps mentioned in the | |||
There was a problem hiding this comment.
Can you summarize the breaking change in one or two sentences here? In this Rook upgrade guide, they should understand if they are affected, and if it's common. By default, users won't be affected, right? I don't expect it's common to use the mount options. For example, say that if they are setting the mountOptions in a CephFS storage class, they need to follow those instructions in the CSI upgrade guide.
There was a problem hiding this comment.
👍 yes
Updated mentioning the above suggested details,
Ptal
Rakshith-R
force-pushed
the
cephfs-breaking-change
branch
from
1668668
to
d42fc0b
Compare
CephCSI CephFS introduced a breaking change in v3.9.0. This commit adds a note in upgrade guide regarding the same. refer: https://github.com/ceph/ceph-csi/blob/v3.9.0/docs/ \ ceph-csi-upgrade.md/#upgrading-cephfs Signed-off-by: Rakshith R <rar@redhat.com>
Rakshith-R
force-pushed
the
cephfs-breaking-change
branch
from
d42fc0b
to
a211368
Compare
travisn
approved these changes
Aug 1, 2023
travisn
added a commit
that referenced
this pull request
Aug 1, 2023
docs: add note in upgrade guide about cephfs driver's breaking change (backport #12615)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
CephCSI CephFS introduced a breaking change in v3.9.0. This commit adds a note in upgrade guide regarding the same.
refer: https://github.com/ceph/ceph-csi/blob/v3.9.0/docs/ceph-csi-upgrade.md/#upgrading-cephfs
Checklist:
skip-cion the PR.