Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: fix formatting of some logger methods #12666

Merged
merged 1 commit into from
Aug 4, 2023
Merged

operator: fix formatting of some logger methods #12666

merged 1 commit into from
Aug 4, 2023

Conversation

polyedre
Copy link
Contributor

@polyedre polyedre commented Aug 4, 2023

Some logging instructions use formatting syntax %q, but the logging method is Info or Debug instead of Debugf and Infof. As a result, the arguments of the method were concatenated instead of formatted properly.

Which issue is resolved by this Pull Request:

No issue.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@polyedre
operator: fix formatting of some logger methods
c948183 
Some logging instructions use formatting syntax `%q`, but the logging method is
`Info` or `Debug` instead of `Debugf` and `Infof`. As a result, the arguments of
the method were concatenated instead of formatted properly.

Signed-off-by: Lucas Henry <polyedre@disroot.org>
subhamkrai
subhamkrai approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

travisn
travisn approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Commonly the linters catch issues like this, i'm curious why they weren't caught...

@travisn travisn merged commit 7aaf46e into rook:master Aug 4, 2023
46 of 49 checks passed
This was referenced Aug 4, 2023
Merged
Merged
travisn added a commit that referenced this pull request Aug 4, 2023
@travisn
Merge pull request #12668 from rook/mergify/bp/release-1.11/pr-12666
c4f7e5a 
operator: fix formatting of some logger methods (backport #12666)
travisn added a commit that referenced this pull request Aug 4, 2023
@travisn
Merge pull request #12669 from rook/mergify/bp/release-1.12/pr-12666
27219da 
operator: fix formatting of some logger methods (backport #12666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@subhamkrai subhamkrai subhamkrai approved these changes

Assignees
No one assigned
Labels
backport-release-1.11 backport-release-1.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@polyedre @travisn @subhamkrai