build: Remove go modules under apis directory #12764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go package dependencies (go.mod and go.sum) were created under the pkg/apis directory to simplify the dependencies for other projects referencing the rook repo. The downside is that the dependabot can no longer open a working and valid PR since the bot is not aware of the go.mod and go.sum in the apis directory. Since the reduction of dependencies for vault in rook#12455, the list of extra dependencies is not quite so extensive. We are putting effort into shrinking the dependency list instead of using the modules files in the apis subdirectory. Note that rook#12419 updated the dependencies for the latest controller runtime which also increased the size of the modules list in the pkgs subdirectory, which means the difference in dependencies in the pkgs subdirectory is no longer signficant anyway. Signed-off-by: travisn <tnielsen@redhat.com>
Run make go.mod.update to update the go modules to the latest references. Signed-off-by: travisn <tnielsen@redhat.com>
BlaineEXE
approved these changes
Aug 22, 2023
parth-gr
reviewed
Aug 22, 2023
| @cp -a go.sum pkg/apis/go.sum | ||
| @cat go.mod | sed -e 's|^module github.com/rook/rook|module github.com/rook/rook/pkg/apis|' \ | ||
| -e '\:^replace github.com/rook/rook/pkg/apis => ./pkg/apis:d' > pkg/apis/go.mod | ||
| @echo === ensuring APIs modules are tidied |
There was a problem hiding this comment.
not sure but this was present before too
https://github.com/rook/rook/pull/12160/files#diff-7a99b55c9955c9204d3d3045ade8dc665390fff27f0b5b5837340015f28ff56f
There was a problem hiding this comment.
It looks like the "APIs modules" was not present, but "ensuring modules" was. IMO, this is pretty minor anyway
travisn
added a commit
that referenced
this pull request
Aug 22, 2023
build: Remove go modules under apis directory (backport #12764)
7 tasks
Closed
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The go package dependencies (go.mod and go.sum) were created under the pkg/apis directory to simplify the dependencies for other projects referencing the rook repo. The downside is that the dependabot can no longer open a working and valid PR since the bot is not aware of the go.mod and go.sum in the apis directory.
Since the reduction of dependencies for vault in #12455, the list of extra dependencies is not quite so extensive. We are putting effort into shrinking the dependency list instead of using the modules files in the apis subdirectory. See also #12663.
Note that #12419 updated the dependencies for the latest controller runtime which also increased the size of the modules list in the pkgs subdirectory, which means the difference in dependencies in the pkgs subdirectory is no longer signficant anyway.
Checklist:
skip-cion the PR.