Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: update docs/comments to reflect reef support #12872

Merged
merged 1 commit into from
Sep 8, 2023
Merged

helm: update docs/comments to reflect reef support #12872

merged 1 commit into from
Sep 8, 2023

Conversation

mjnagel
Copy link
Contributor

@mjnagel mjnagel commented Sep 8, 2023 •
edited

Description of your changes:

Clarifies docs/helm comments that seem to indicate v18 is not supported.

Which issue is resolved by this Pull Request:

Closes #12871

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@mjnagel
Copy link
Contributor Author

mjnagel commented Sep 8, 2023 •
edited

Looks like I can't add labels to the PR (skip-ci) - is there a way for me to add that label? And/or should I have done it via commit the "standard" github way?

@mjnagel mjnagel changed the title docs: update docs to reflect reef support docs/helm: update docs to reflect reef support Sep 8, 2023
@mjnagel mjnagel changed the title docs/helm: update docs to reflect reef support helm: update docs/comments to reflect reef support Sep 8, 2023
@travisn travisn added the skip-ci label Sep 8, 2023
travisn
travisn requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update to the docs! Looks like there is just an extra character.

deploy/charts/rook-ceph-cluster/values.yaml Outdated Show resolved Hide resolved
@mjnagel
helm: update docs to reflect reef support
0ff224d 
some helm comments incorrectly indicate ceph v18 is not supported

Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
@travisn travisn merged commit a64f9bc into rook:master Sep 8, 2023
44 checks passed
@mergify mergify bot mentioned this pull request Sep 8, 2023
Merged
@mjnagel mjnagel deleted the docs-fixes-reef-support branch September 8, 2023 19:19
travisn added a commit that referenced this pull request Sep 12, 2023
@travisn
Merge pull request #12873 from rook/mergify/bp/release-1.12/pr-12872
7e64b9c 
helm: update docs/comments to reflect reef support (backport #12872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
backport-release-1.12 skip-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: examples/helm charts indicate ceph v18 is not supported
2 participants
@mjnagel @travisn