exporter: bind to all interfaces if IPv6 is enabled #12886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanthakkar
reviewed
Sep 12, 2023
matthewpi
changed the title
--addrs :: argument
Previously ceph-exporter would only bind to IPv4 interfaces. Now if the CephCluster is configured with `dualStack: true` and/or `ipFamily: IPv6` an additional flag (`--addrs ::`) will be added to the ceph-exporter container to make it listen both IPv6 and IPv4 interfaces. Signed-off-by: Matthew Penner <me@matthewp.io>
travisn
approved these changes
Sep 12, 2023
travisn
added a commit
that referenced
this pull request
Sep 12, 2023
exporter: bind to all interfaces if IPv6 is enabled (backport #12886)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Adds a new argument to the
ceph-exportercontainer that causes it to bind to bothIPv4andIPv6interfaces. Without the flag the exporter will only bind to IPv4 which causes the exporter to not be scraped correctly when the cluster prefers IPv6 over IPv4 (Kubernetes is ran with--cluster-cidr=<IPv6>,<IPv4>, instead of IPv4 being first).Which issue is resolved by this Pull Request:
Resolves #12885
Checklist: