Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: use crash profile in crash daemon keyring #12970

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

travisn
Copy link
Member

@travisn travisn commented Sep 28, 2023

Description of your changes:
The ceph documentation indicates to use the crash profile instead of specifying rw for the mgr access.

This is tested with pacific, quincy, and reef with the profile change. In each case, a crash dump was able to be reported successfully and displayed in the dashboard.

See the crash keyring recommendation in ceph docs.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

The ceph documentation indicates to use the crash profile
instead of specifying rw for the mgr access.

Signed-off-by: travisn <tnielsen@redhat.com>
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travisn travisn merged commit 91c0df9 into rook:master Oct 2, 2023
50 checks passed
@travisn travisn deleted the crash-profile branch October 2, 2023 13:26
travisn added a commit that referenced this pull request Oct 4, 2023
core: use crash profile in crash daemon keyring (backport #12970)
@rspier
Copy link
Contributor

rspier commented Oct 20, 2023

This change appears to break the rook-ceph-crashcollector-pruner cronjob.

See discussion in https://app.slack.com/client/T47C56S7Q/CK9CF5H2R/thread/CK9CF5H2R-1697689338.403619

Copy link

@abh abh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance of having this merged into 1.12.x ? I think it'd resolve the alerts we get about the crash pruner crashing.

@travisn
Copy link
Member Author

travisn commented Oct 23, 2023

The fix from #13072 is merged and backported to 1.12 and will be included in the v1.12.7 release. For an interim release image with the fix, you could deploy rook/ceph:v1.12.6-4.g9e664c19e. v1.12.7 wasn't planned until next week, but I'm thinking we can target later this week for the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants