external: fix client.healthchecker user keyring return #13001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parth-gr
force-pushed
the
external-healtchker
branch
from
994d4b0
to
e7aced8
Compare
parth-gr
changed the title
if the client.health checker already exited it was returning extra information, It was making the structure and return JSON non idempotent output, So fixed that problem by returning a single value Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr
force-pushed
the
external-healtchker
branch
5 times, most recently
from
f140562
to
467b3f7
Compare
travisn
reviewed
Oct 5, 2023
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr
force-pushed
the
external-healtchker
branch
from
467b3f7
to
98125c7
Compare
travisn
reviewed
Oct 5, 2023
| @@ -1162,7 +1162,7 @@ def create_checkerKey(self, user): | |||
| # check if user already exist | |||
| user_key = self.check_user_exist(entity) | |||
| if user_key != "": | |||
| return user_key, f"{entity.split('.', 1)[1]}" | |||
There was a problem hiding this comment.
So this was a regression from #12941? The second return value was just not needed?
travisn
approved these changes
Oct 5, 2023
travisn
added a commit
that referenced
this pull request
Oct 5, 2023
external: fix client.healthchecker user keyring return (backport #13001)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
if the client.health checker already exited it was returning extra information,
It was making the structure and return JSON non idempotent output , So fixed that problem by returning a single value
Which issue is resolved by this Pull Request:
Resolves #
Checklist: