osd: print warning message if no matching node found for osd #13046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @subhamkrai , I'm not really familiar with the tests. Do you think those 2 failures are related to this PR? |
travisn
requested changes
Oct 16, 2023
No, I didn't test it manually since it's hard for me to build and deploy it locally. (It's only a homelab setup and I don't have much resource to do it). This is a simple change and passed other tests so maybe it's enough? Of course it will be great if someone else want to test it manually. |
travisn
requested changes
Oct 16, 2023
As seen in rook#1988, it's a common mistake to configure rook nodes with names that don't match Kubernetes's node label. This PR prints more detailed message to help debugging problem. Signed-off-by: Bin Wang <bin.wang@mail.binwang.me> Add break according to review comment Co-authored-by: Travis Nielsen <tnielsen@redhat.com> Update log message according to review comment Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
travisn
approved these changes
Oct 17, 2023
travisn
added a commit
that referenced
this pull request
Oct 18, 2023
osd: print warning message if no matching node found for osd (backport #13046)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
As seen in #1988, it's a common mistake to configure rook nodes with names that don't match Kubernetes's node label. This PR prints more detailed message to help debugging problem.
Which issue is resolved by this Pull Request:
Resolves #
Checklist: