namespace: adding namespace to all rook-ceph namespaces references #13078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkachach
force-pushed
the
fix_issue_namespace
branch
from
90c45b7
to
f325318
Compare
travisn
requested changes
Oct 23, 2023
| @@ -9,4 +9,4 @@ spec: | |||
| schedulingInterval: "12m" | |||
| schedulingStartTime: "16:18:43" | |||
| replication.storage.openshift.io/replication-secret-name: rook-csi-rbd-provisioner | |||
| replication.storage.openshift.io/replication-secret-namespace: rook-ceph | |||
| replication.storage.openshift.io/replication-secret-namespace: rook-ceph # namespace:cluster | |||
There was a problem hiding this comment.
@Rakshith-R This is the csi driver namespace, right? So it would be the operator tag.
Suggested change
| replication.storage.openshift.io/replication-secret-namespace: rook-ceph # namespace:cluster | |
| replication.storage.openshift.io/replication-secret-namespace: rook-ceph # namespace:operator |
There was a problem hiding this comment.
well, let's wait for the confirmation from @Rakshith-R but as I can see on my local cluster all the csi related config is part of the operator namespace.
rkachach
force-pushed
the
fix_issue_namespace
branch
from
d3c9e5b
to
d1a13b2
Compare
To make it easier for the user to switch to a namespace other than the default 'rook-ceph', the tag '# namespace:cluster' must be inserted in all the places where this namespace is used. This way, a simple 'sed' command can update all the Yaml files to the new namespace. Signed-off-by: Redouane Kachach <rkachach@redhat.com>
rkachach
force-pushed
the
fix_issue_namespace
branch
from
60840f1
to
ff081cc
Compare
travisn
approved these changes
Oct 24, 2023
travisn
added a commit
that referenced
this pull request
Oct 24, 2023
namespace: adding namespace to all rook-ceph namespaces references (backport #13078)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
To make it easier for the user to switch to a namespace other than the default 'rook-ceph', the tag '# namespace:cluster' must be inserted in all the places where this namespace is used. This way, a simple 'sed' command can update all the Yaml files to the new namespace.
related docs: https://rook.github.io/docs/rook/v1.9/ceph-advanced-configuration.html
Which issue is resolved by this Pull Request:
Resolves #
Checklist: