Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace: adding a dedicated entry for operator namespace in common #13080

Merged
merged 1 commit into from Oct 24, 2023

Conversation

rkachach
Copy link
Contributor

@rkachach rkachach commented Oct 23, 2023

Description of your changes:

Up to this point, we've been using a single entry for the namespace, which works perfectly when utilizing the default 'rook-ceph' namespace. However, when a user attempts to adhere to the documentation to use alternative namespaces for both the operator and the cluster, they fail because our common YAML file only has a single namespace for the cluster. To solve this issue, users must create the operator namespace manually in case it's different from the cluster namespace.

Closes: #13079
Related: #11883

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@rkachach rkachach requested review from BlaineEXE, travisn and a team October 23, 2023 13:40
@rkachach rkachach force-pushed the fix_issue_13079 branch 2 times, most recently from 3fefb95 to 46815b1 Compare October 23, 2023 16:20
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small formatting suggestions

When a user attempts to adhere to the current documentation to use alternative
namespaces for both the operator and the cluster, they fail because
our common YAML file only has a single namespace for the cluster. This
change adds specific instructions to create operator namespace.

Closes: rook#13079

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@travisn travisn merged commit 8229e9e into rook:master Oct 24, 2023
17 of 18 checks passed
travisn added a commit that referenced this pull request Oct 24, 2023
namespace: adding a dedicated entry for operator namespace in common (backport #13080)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation to use alternate namespaces is missing some details
2 participants