Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: unifying namespaces handling for the second cluster creation #13089

Merged
merged 1 commit into from Oct 25, 2023
Merged

docs: unifying namespaces handling for the second cluster creation #13089

merged 1 commit into from Oct 25, 2023

Conversation

rkachach
Copy link
Contributor

Description of your changes:

Let's use the same technique based on 'sed' while employing two different namespaces for the cluster and the operator when creating the second cluster.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@rkachach rkachach requested review from travisn, BlaineEXE and a team October 24, 2023 12:48
@rkachach rkachach requested a review from travisn October 24, 2023 15:14
travisn
travisn requested changes Oct 24, 2023
View reviewed changes
deploy/examples/common-second-cluster.yaml Outdated Show resolved Hide resolved
deploy/examples/common-second-cluster.yaml Outdated Show resolved Hide resolved
deploy/examples/common-second-cluster.yaml Outdated Show resolved Hide resolved
deploy/examples/common-second-cluster.yaml Outdated Show resolved Hide resolved
deploy/examples/common-second-cluster.yaml Outdated Show resolved Hide resolved
Documentation/Storage-Configuration/Advanced/ceph-configuration.md Outdated Show resolved Hide resolved
Documentation/Storage-Configuration/Advanced/ceph-configuration.md Show resolved Hide resolved
Documentation/Storage-Configuration/Advanced/ceph-configuration.md Outdated Show resolved Hide resolved
@rkachach rkachach requested a review from travisn October 24, 2023 17:15
@rkachach rkachach force-pushed the fix_issue_second_cluster branch 2 times, most recently from 31f4ba4 to 1ab9c7d Compare October 24, 2023 17:31
@rkachach
docs: unifying namespaces handling for the second cluster creation
13654d3 
Let's use the same technique based on 'sed' while employing two
different namespaces for the cluster and the operator when creating
the second cluster.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@rkachach rkachach requested a review from travisn October 25, 2023 07:17
@travisn travisn merged commit 72452f0 into rook:master Oct 25, 2023
51 checks passed
@mergify mergify bot mentioned this pull request Oct 25, 2023
Merged
travisn added a commit that referenced this pull request Oct 25, 2023
@travisn
Merge pull request #13104 from rook/mergify/bp/release-1.12/pr-13089
489b9b4 
docs: unifying namespaces handling for the second cluster creation (backport #13089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlaineEXE BlaineEXE BlaineEXE left review comments

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
backport-release-1.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rkachach @travisn @BlaineEXE