multus: improve the multus validation test's flakiness metric #13123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheetalpamecha
force-pushed
the
mmultus-validation-test
branch
from
6bd9cb5
to
c061c33
Compare
BlaineEXE
requested changes
Oct 30, 2023
pkg/daemon/multus/config.go
Outdated
Comment on lines
49
to
50
| DefaultValidationFlakyThreshold = 20 * time.Second | ||
|
|
There was a problem hiding this comment.
Unless you can provide solid evidence that changing this value is for the better, let's default to 30 seconds since that is the current behavior.
There was a problem hiding this comment.
Okay modified to 30 seconds. I just referenced it from https://github.com/rook/rook/blob/master/pkg/daemon/multus/validation.go#L325
var flakyThreshold = 20 * time.Second
BlaineEXE
requested changes
Oct 30, 2023
Sheetalpamecha
force-pushed
the
mmultus-validation-test
branch
3 times, most recently
from
657a0f3
to
d3ae893
Compare
Allow the flakiness threshold window to be tuned from the cli Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
Sheetalpamecha
force-pushed
the
mmultus-validation-test
branch
from
d3ae893
to
06c1765
Compare
BlaineEXE
approved these changes
Nov 1, 2023
BlaineEXE
added a commit
that referenced
this pull request
Nov 1, 2023
multus: improve the multus validation test's flakiness metric (backport #13123)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the flakiness threshold window to be tuned from the cli
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #12176
Checklist: