Revert "osd: support encrypted OSD on partiton" #13169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0931259. Once we introduced encrypted OSD on partition in rook#12924. However, even though `encryptedDevice` field is `true`, an non-encrypted OSD is created. To prevent the creation of misconfigured OSD, it's better to revert rook#12924 for now. Initially, I intended to correct this problem. However, I found it will take long time because we need to change the KMS-related code, init containers of both OSD pod and OSD prepare pod. Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
|
NOTE: |
travisn
approved these changes
Nov 8, 2023
|
Although objectstore test and csi-hostname-disable fails consistently. These failures are under investigation and this PR apparently does not affect these tests. |
travisn
added a commit
that referenced
this pull request
Nov 10, 2023
Revert "osd: support encrypted OSD on partiton" (backport #13169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0931259.
Once we introduced encrypted OSD on partition in #12924. However, even though
encryptedDevicefield istrue, an non-encrypted OSD is created. To prevent the creation of misconfigured OSD, it's better to revert #12924 for now.Initially, I intended to correct this problem. However, I found it will take a long time because we need to change the KMS-related code, init containers of both OSD pod and OSD prepare pod.
Checklist: