helm: allow configuring monitoring interval #13408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Haley <charlie.haley@hotmail.com>
charlie-haley
force-pushed
the
monitoring-interval
branch
from
1bd8f09
to
0768eb1
Compare
travisn
approved these changes
Dec 15, 2023
|
Was there a github issue for this, or just discussed in slack? Just wanted to make sure the issue was closed if there was one. |
This was referenced Dec 15, 2023
|
Hey, there wasn't a GitHub issue for this, it also wasn't discussed in Slack. I just decided to add it after following on from this issue here - #13159 |
Perfect, that's the issue I was thinking of. |
travisn
added a commit
that referenced
this pull request
Dec 19, 2023
helm: allow configuring monitoring interval (backport #13408)
travisn
added a commit
that referenced
this pull request
Dec 19, 2023
helm: allow configuring monitoring interval (backport #13408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
monitoring.intervalproperty to the helm chart so the scrape interval can be configured beyond the default 5s.Which issue is resolved by this Pull Request:
Resolves #
Checklist: