object: add check specific to name and namespace for ceph cosi driver #13623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlaineEXE
reviewed
Jan 25, 2024
| // Set the default CephCOSIDriver name if not already set | ||
| if cephCOSIDriver.Name == "" { | ||
| cephCOSIDriver.Name = CephCOSIDriverName | ||
| // The ceph-cosi-driver CRD must have the name "ceph-cosi-driver" |
There was a problem hiding this comment.
Why? This seems like an unnecessary limitation when the operator can just know to query for a single CephCOSIDrivers in the operator namespace.
thotz
force-pushed
the
ceph-cosi-driver-name-namespace-check
branch
from
f4108c9
to
613b5a1
Compare
travisn
requested changes
Jan 29, 2024
thotz
force-pushed
the
ceph-cosi-driver-name-namespace-check
branch
from
9b0eecf
to
6d57324
Compare
The name for cephcosi driver should be ceph-cosi-driver and namespace should same as the rook operator. Otherwise request need to be failed. Fixes: rook#13025 Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
thotz
force-pushed
the
ceph-cosi-driver-name-namespace-check
branch
from
6d57324
to
5b5e1c0
Compare
travisn
reviewed
Jan 31, 2024
|
Test on my minikube setup logs: |
BlaineEXE
approved these changes
Feb 5, 2024
travisn
approved these changes
Feb 5, 2024
travisn
added a commit
that referenced
this pull request
Feb 6, 2024
object: add check specific to name and namespace for ceph cosi driver (backport #13623)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name for cephcosi driver should be ceph-cosi-driver and namespace should same as the rook operator. Otherwise request need to be failed.
Fixes: #13025
Checklist: