Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disk in github action increased to 75G from 64G #13675

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

subhamkrai
Copy link
Contributor

the disk size in the github action machine has
increased from 64G to 75G.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@sp98
Copy link
Contributor

sp98 commented Feb 5, 2024

@subhamkrai Can you check if this is something we can fix on the fly? So don't have to fix it again if the disk size increases in future.

@sp98
Copy link
Contributor

sp98 commented Feb 5, 2024

@subhamkrai Can you check if this is something we can fix on the fly? So don't have to fix it again if the disk size increases in future.

Other option would have have this is a global variable. So future change in the disk size can go only in file only.

@subhamkrai
Copy link
Contributor Author

@subhamkrai Can you check if this is something we can fix on the fly? So don't have to fix it again if the disk size increases in future.

Other option would have have this is a global variable. So future change in the disk size can go only in file only.

I agree we need do better work handling this, will work on this in separate PR later

@travisn
Copy link
Member

travisn commented Feb 5, 2024

As discussed we will get this merged to handle the new disk size, then follow up to investigate the remaining CI failures. At least this gives us green CI for some of the integration tests where a single OSD is used.

@subhamkrai subhamkrai force-pushed the ci-fix-disk-size branch 2 times, most recently from 7eb03fa to 0c5ca8e Compare February 5, 2024 16:40
@subhamkrai
Copy link
Contributor Author

sudo lsblk --paths --list | grep -P '\s+/mnt$' | grep -Po '^[/a-z]+'|

This not working once we do formatting or partition change for canary-tests

the disk size in the github action machine has
increased from 64G to 75G. Now, we detech the version
automatically not fetching hard coded value.

Co-authored-by: Jan Klippel <jan.klippel@uhurutec.com>
Signed-off-by: subhamkrai <srai@redhat.com>
@subhamkrai
Copy link
Contributor Author

I tried few things, but that didn't worked so I guess ready for review

@travisn
Copy link
Member

travisn commented Feb 5, 2024

I tried few things, but that didn't worked so I guess ready for review

Ok, we can follow up separately on how to avoid the size-based filter. Will merge once the CI is completed.

@BlaineEXE
Copy link
Member

This is the second time GH has changed the disk size in 3ish months I think. We probably should figure out how to use a different filter for selecting the disk.

@travisn
Copy link
Member

travisn commented Feb 5, 2024

I tried few things, but that didn't worked so I guess ready for review

@subhamkrai Which tests do you expect to fail even after the size change? Just some canary tests? Looks like some upgrade and other integration tests are also failing, even though I thought I had seen them pass on a previous run.

@subhamkrai
Copy link
Contributor Author

I tried few things, but that didn't worked so I guess ready for review

@subhamkrai Which tests do you expect to fail even after the size change? Just some canary tests?

Yes,

Looks like some upgrade and other integration tests are also failing, even though I thought I had seen them pass on a previous run.

@travisn seems like those tested are cancelled in the middle not failed.

@subhamkrai
Copy link
Contributor Author

seems like the CI started with debug mode and then cancelled

Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the CI started with debug mode and then cancelled

Going ahead with the merge, and will keep investigating the remaining issues with a separate PR...

@travisn travisn merged commit 577c7cc into rook:master Feb 5, 2024
37 of 50 checks passed
travisn added a commit that referenced this pull request Feb 6, 2024
ci: disk in github action increased to 75G from 64G (backport #13675)
travisn added a commit that referenced this pull request Feb 6, 2024
ci: disk in github action increased to 75G from 64G (backport #13675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants