-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: disk in github action increased to 75G from 64G #13675
Conversation
ad43b26
to
1b96cac
Compare
@subhamkrai Can you check if this is something we can fix on the fly? So don't have to fix it again if the disk size increases in future. |
Other option would have have this is a global variable. So future change in the disk size can go only in file only. |
I agree we need do better work handling this, will work on this in separate PR later |
1de395f
to
1b96cac
Compare
1b96cac
to
3acdf28
Compare
As discussed we will get this merged to handle the new disk size, then follow up to investigate the remaining CI failures. At least this gives us green CI for some of the integration tests where a single OSD is used. |
7eb03fa
to
0c5ca8e
Compare
This not working once we do formatting or partition change for canary-tests |
0c5ca8e
to
246956f
Compare
the disk size in the github action machine has increased from 64G to 75G. Now, we detech the version automatically not fetching hard coded value. Co-authored-by: Jan Klippel <jan.klippel@uhurutec.com> Signed-off-by: subhamkrai <srai@redhat.com>
246956f
to
6b0deb3
Compare
I tried few things, but that didn't worked so I guess ready for review |
Ok, we can follow up separately on how to avoid the size-based filter. Will merge once the CI is completed. |
This is the second time GH has changed the disk size in 3ish months I think. We probably should figure out how to use a different filter for selecting the disk. |
@subhamkrai Which tests do you expect to fail even after the size change? Just some canary tests? Looks like some upgrade and other integration tests are also failing, even though I thought I had seen them pass on a previous run. |
Yes,
@travisn seems like those tested are cancelled in the middle not failed. |
seems like the CI started with debug mode and then cancelled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the CI started with debug mode and then cancelled
Going ahead with the merge, and will keep investigating the remaining issues with a separate PR...
ci: disk in github action increased to 75G from 64G (backport #13675)
ci: disk in github action increased to 75G from 64G (backport #13675)
the disk size in the github action machine has
increased from 64G to 75G.
Checklist: