Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow legacy hostNetwork together with non-default provider #13693

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Disallow legacy hostNetwork together with non-default provider #13693

merged 2 commits into from
Feb 13, 2024

Commits on Feb 12, 2024

  1. ci: add "network" to the allowed commit message prefixes 

    Signed-off-by: Michael Adam <obnox@samba.org>
    @obnoxxx
    obnoxxx committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c38612c View commit details
    Browse the repository at this point in the history

  2. network: disallow legacy hostNetwork together with non-default provider 

    Fixes: rook#13692

Since the introduction of the "host" network provider, the  legacy
"hostNetwork" setting is intended to be used only in combination with
the default network provider (""), but the code did not enforce this.

This change adds the required validation checks to throw errors
in invalid constellations.

These checks are added both in the operator's input  validation code
and as kubernetes x-validation admission policies in the Cepcluster CRD.

Signed-off-by: Michael Adam <obnox@samba.org>
    @obnoxxx
    obnoxxx committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    25aa15e View commit details
    Browse the repository at this point in the history