Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove ownerRef from networkFence #13728

Merged
merged 1 commit into from Feb 8, 2024

Conversation

subhamkrai
Copy link
Contributor

since networkFence is a cluster-based resource so that we don't need the namespace and ownerReferences as it cause garbage-collector errors.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

since networkFence is a cluster-based resource so that we don't need
the namespace and ownerReferences as it cause garbage-collector errors.

Signed-off-by: subhamkrai <srai@redhat.com>
@travisn travisn merged commit ebcb0a4 into rook:master Feb 8, 2024
50 checks passed
travisn added a commit that referenced this pull request Feb 8, 2024
core: remove ownerRef from networkFence (backport #13728)
travisn added a commit that referenced this pull request Feb 8, 2024
core: remove ownerRef from networkFence (backport #13728)
@subhamkrai subhamkrai deleted the remove-ownerRef-nf branch February 9, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants