New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr: remove privileged security context from mgr sidecar container #13741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integration tests are passing, so if manual testing looks good, this should be good to go after a couple other small CI issues are fixed.
rkachach
force-pushed
the
fix_issue_13719
branch
from
February 12, 2024 09:12
d35cb30
to
08643a3
Compare
rkachach
changed the title
[WIP] mgr: remove privileged security context from mgr sidecar container
mgr: remove privileged security context from mgr sidecar container
Feb 12, 2024
rkachach
force-pushed
the
fix_issue_13719
branch
from
February 12, 2024 09:16
08643a3
to
c7f9d99
Compare
parth-gr
reviewed
Feb 12, 2024
travisn
approved these changes
Feb 12, 2024
parth-gr
reviewed
Feb 13, 2024
rkachach
force-pushed
the
fix_issue_13719
branch
3 times, most recently
from
February 13, 2024 13:02
821a5d0
to
e60b9c3
Compare
Mgr sidecar was using a privileged security context because it needed to create the /var/lib/rook directory, generate the config on it, and then copy it to the /etc/ceph directory. This change creates empty directories on /var/lib/rook and /etc/ceph so the mgr sidecar can use them, removing the need for using a privileged security context. Fixes: rook#13719 Signed-off-by: Redouane Kachach <rkachach@redhat.com>
rkachach
force-pushed
the
fix_issue_13719
branch
from
February 13, 2024 13:03
324d6d3
to
db4b332
Compare
travisn
added a commit
that referenced
this pull request
Feb 13, 2024
mgr: remove privileged security context from mgr sidecar container (backport #13741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mgr sidecar was using a privileged security context because it needed
to create the
/var/lib/rook
directory, generate the config on it, andthen copy it to the
/etc/ceph
directory. This change creates emptydirectories on
/var/lib/rook
and/etc/ceph
so the mgr sidecar can usethem, removing the need for using a privileged security context.
Issue resolved by this Pull Request:
Fixes: #13719
Manual testing:
Mgr sidecar
watch-active
is running without issues both on the active and on the mgr standby pods:Checklist: