csi: remove cephFs networkFence code temporarily #13806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update go.mod to use csi-addons version v0.8.0. Signed-off-by: subhamkrai <srai@redhat.com>
earlier, we were only checking the specs of networkFence to see if unfencing is done before proceeding with deletion but we should also check the status of networkFence before proceeding with deletion. Signed-off-by: subhamkrai <srai@redhat.com> (cherry picked from commit 0ace7cf)
cephFs fencing needs more testing and bug fixes to make it in production. We tried multiple fixes but still it need more work. So, removing the cephfs networkFence realted code will rever this commit when we start working on this again. Signed-off-by: subhamkrai <srai@redhat.com> (cherry picked from commit bd4250f)
|
Hi @subhamkrai, this pull request was opened against a release branch, is it expected? Normally patches should go in the master branch first and then be backported to release branches. |
Madhu-1
approved these changes
Feb 22, 2024
|
@travisn Manually backport is required as 1.13 branch was using csi-addons 0.7.0 but we 0.8.0 with the latest changes |
subhamkrai
commented
Feb 22, 2024
| @@ -604,8 +449,8 @@ func (c *clientCluster) unfenceAndDeleteNetworkFence(ctx context.Context, node c | |||
| return false, err | |||
| } | |||
|
|
|||
| if networkFence.Spec.FenceState != addonsv1alpha1.Unfenced { | |||
| logger.Infof("waiting for network fence CR %s to get in %s state before deletion", networkFence.Name, addonsv1alpha1.Unfenced) | |||
| if networkFence.Status.Message != addonsv1alpha1.UnFenceOperationSuccessfulMessage { | |||
There was a problem hiding this comment.
Suggested change
| if networkFence.Status.Message != addonsv1alpha1.UnFenceOperationSuccessfulMessage { | |
| if networkFence.Status.Message != addonsv1alpha1.UnFenceOperationSuccessfulMessage { |
This check requires csi-addons v0.8.0
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check individual commit messages
Issue resolved by this Pull Request:
Resolves #13805
Checklist: